libgpiod: Make Python bindings optional by ernestask · Pull Request #29165 · openwrt/packages

ernestask · 2026-04-16T13:59:52Z

📦 Package Details

Maintainer: @mhei

Description:
python3-gpiod causes python3-light to be built even if not selected, which can be avoided by making the dependency conditional`.

How to test:

Select gpiod-tools
make package/libgpiod/compile

Without the changes: python3 (and bluez) get built as dependencies
With the changes: python3 is not built

🧪 Run Testing Details

OpenWrt Version: 9247eb400241cd2b6f3ec141744b560dcf59c8db
OpenWrt Target/Subtarget: mediatek/filogic
OpenWrt Device: openwrt-one

✅ Formalities

I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

pprindeville

Nix on the isc-dhcp changes.

pprindeville · 2026-04-16T16:27:16Z

-	+bind-server \
-	+bind-rndc \
-	+bind-client
+	+PACKAGE_isc-dhcp-dyndns:bind-server \


I don't get this. Look at the install directions for this package. It doesn't do anything but make sure dependencies are satisfied. It's a meta-package. Making the dependencies conditional would defeat the purpose of having it.

The install section is irrelevant here, but perhaps I haven’t expressed myself properly, so let me try to explain my problem again

scripts/package-metadata.pl will parse the package and spit out a line like this to tmp/.packagedeps (which is then used for ordering builds):

$(curdir)/feeds/packages/isc-dhcp/compile += $(curdir)/feeds/packages/bind/compile $(curdir)/libs/toolchain/compile $(curdir)/libs/zlib/compile

That means that if I select, say PACKAGE_isc-dhcp-relay-ipv6, in my config and leave PACKAGE_isc-dhcp-dyndns unselected, bind will still be built as a build dependency.

With the change, it would look more like this:

$(curdir)/feeds/packages/isc-dhcp/compile += $(curdir)/libs/toolchain/compile $(curdir)/libs/zlib/compile $(if $(CONFIG_PACKAGE_isc-dhcp-dyndns),$(curdir)/feeds/packages/bind/compile)

…and my build times would become ever-so-slightly shorter (the worse offender in my case is libgpiod with Python).

An existing example: 0c245fd

Still not getting it. All of this is inside the definition of the subpackage isc-dhcp-dyndns so why would any of it take effect if that package isn't already selected? Isn't what you're doing redundant?

Due to how the package scripts work overall, it’s not redundant, unfortunately. All of the (sub-)package dependencies within a Makefile are collected and become implicit build dependencies, whether a particular subpackage is enabled or not (just picking any one is enough, because they are per-directory).

It could be “fixed” (it’s not a bug per se, more a build time optimization) by doing the same for all packages by default, but quite a few packages unknowingly rely on implicit behavior and would need fixing to get dependencies right, so I’m cherry-picking individual package changes I made.

It’s pretty much only noticable when building n+1 times a day and looking at the make output.

mhei · 2026-04-17T04:55:13Z

The libgpiod changes LGTM for a first quick look, will have a deeper one today evening or tomorrow.

mhei · 2026-04-26T19:20:36Z

+else
+CONFIGURE_ARGS += --disable-bindings-python
+endif
+


This part does not work well: the python bindings are disabled by default and there is no auto-magic to enable them. On the other hand, passing --enable-bindings-python does not work for me in my local build: the build pulls in host python and fails to build. This is why the whole python build magic is wrapped later with Py3Package,python3-gpiod which sets the correct build environment (but it is not set already during "normal" package build).
I think you should drop this chunk.

commodo · 2026-05-01T05:31:22Z

Build failure is

2.1.3 -Wl,-z,max-page-size=4096 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -Wl,-z,pack-relative-relocs " PYO3_CROSS_LIB_DIR="/builder/staging_dir/target-i386_pentium-mmx_musl/usr/lib/python3.14" SETUPTOOLS_RUST_CARGO_PROFILE="release"  LINK_SYSTEM_LIBGPIOD=1  /builder/staging_dir/hostpkg/bin/python3.14  -m build --no-isolation --outdir "/builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/bindings/python"/openwrt-build --wheel   "/builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/bindings/python" 
2026-04-27T14:20:14.9724038Z * Getting build dependencies for wheel...
2026-04-27T14:20:15.2175629Z 
2026-04-27T14:20:15.2176203Z Traceback (most recent call last):
2026-04-27T14:20:15.2176863Z   File "/builder/staging_dir/hostpkg/lib/python3.14/site-packages/pyproject_hooks/_impl.py", line 402, in _call_hook
2026-04-27T14:20:15.2177437Z     raise BackendUnavailable(
2026-04-27T14:20:15.2177661Z     ...<4 lines>...
2026-04-27T14:20:15.2177835Z     )
2026-04-27T14:20:15.2178147Z pyproject_hooks._impl.BackendUnavailable: Cannot import 'setuptools.build_meta'
2026-04-27T14:20:15.2178460Z 
2026-04-27T14:20:15.2178939Z ERROR Backend 'setuptools.build_meta:__legacy__' is not available.
2026-04-27T14:20:15.2351045Z make[2]: *** [Makefile:170: /builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/.built] Error 1
2026-04-27T14:20:15.2351674Z make[2]: Leaving directory '/feed/libs/libgpiod'
2026-04-27T14:20:15.2354215Z time: package/feeds/packages_ci/libgpiod/compile#55.80#9.30#23.15
2026-04-27T14:20:15.2363399Z     ERROR: package/feeds/packages_ci/libgpiod failed to build.
2026-04-27T14:20:15.2370690Z make[1]: *** [package/Makefile:188: package/feeds/packages_ci/libgpiod/compile] Error 1
2026-04-27T14:20:15.2371385Z make[1]: Leaving directory '/builder'
2026-04-27T14:20:15.2376162Z make: *** [/builder/include/toplevel.mk:226: package/libgpiod/compile] Error 2
2026-04-27T14:20:15.2380511Z ##[group]  make package/index

This may need a PKG_BUILD_DEPENDS:=python-setuptools/host addition.

The python3-light dependency gets lugged even with the package disabled, so this commit makes python3-light a conditional dependency, similar to gensio in 0c245fd. Signed-off-by: Ernestas Kulik <ernestas.k@iconn-networks.com>

If python3-gpiod is enabled and the python-setuptools host package is missing, the setuptools.build_meta import will cause a build failure. Fix this by adding a conditional build dependency.

ernestask · 2026-05-01T09:04:23Z

Build failure is

2.1.3 -Wl,-z,max-page-size=4096 -Wformat -Werror=format-security -fstack-protector -D_FORTIFY_SOURCE=1 -Wl,-z,now -Wl,-z,relro -Wl,-z,pack-relative-relocs " PYO3_CROSS_LIB_DIR="/builder/staging_dir/target-i386_pentium-mmx_musl/usr/lib/python3.14" SETUPTOOLS_RUST_CARGO_PROFILE="release"  LINK_SYSTEM_LIBGPIOD=1  /builder/staging_dir/hostpkg/bin/python3.14  -m build --no-isolation --outdir "/builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/bindings/python"/openwrt-build --wheel   "/builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/bindings/python" 
2026-04-27T14:20:14.9724038Z * Getting build dependencies for wheel...
2026-04-27T14:20:15.2175629Z 
2026-04-27T14:20:15.2176203Z Traceback (most recent call last):
2026-04-27T14:20:15.2176863Z   File "/builder/staging_dir/hostpkg/lib/python3.14/site-packages/pyproject_hooks/_impl.py", line 402, in _call_hook
2026-04-27T14:20:15.2177437Z     raise BackendUnavailable(
2026-04-27T14:20:15.2177661Z     ...<4 lines>...
2026-04-27T14:20:15.2177835Z     )
2026-04-27T14:20:15.2178147Z pyproject_hooks._impl.BackendUnavailable: Cannot import 'setuptools.build_meta'
2026-04-27T14:20:15.2178460Z 
2026-04-27T14:20:15.2178939Z ERROR Backend 'setuptools.build_meta:__legacy__' is not available.
2026-04-27T14:20:15.2351045Z make[2]: *** [Makefile:170: /builder/build_dir/target-i386_pentium-mmx_musl/libgpiod-2.1.3/.built] Error 1
2026-04-27T14:20:15.2351674Z make[2]: Leaving directory '/feed/libs/libgpiod'
2026-04-27T14:20:15.2354215Z time: package/feeds/packages_ci/libgpiod/compile#55.80#9.30#23.15
2026-04-27T14:20:15.2363399Z     ERROR: package/feeds/packages_ci/libgpiod failed to build.
2026-04-27T14:20:15.2370690Z make[1]: *** [package/Makefile:188: package/feeds/packages_ci/libgpiod/compile] Error 1
2026-04-27T14:20:15.2371385Z make[1]: Leaving directory '/builder'
2026-04-27T14:20:15.2376162Z make: *** [/builder/include/toplevel.mk:226: package/libgpiod/compile] Error 2
2026-04-27T14:20:15.2380511Z ##[group]  make package/index

This may need a PKG_BUILD_DEPENDS:=python-setuptools/host addition.

Added a commit to fix that. Though I believe the issue was already present before.

pprindeville requested changes Apr 16, 2026

View reviewed changes

ernestask force-pushed the conditional-deps branch from b7ff358 to 200d050 Compare April 17, 2026 04:16

ernestask changed the title ~~isc-dhcp/libgpiod: Make dependencies conditional~~ libgpiod: Make Python bindings optional Apr 17, 2026

ernestask force-pushed the conditional-deps branch from 200d050 to ffe5dca Compare April 20, 2026 15:41

mhei requested changes Apr 26, 2026

View reviewed changes

ernestask force-pushed the conditional-deps branch 3 times, most recently from e61a910 to 2614c88 Compare April 27, 2026 11:13

ernestask and others added 2 commits May 1, 2026 12:03

libgpiod: make Python bindings optional

65a3708

The python3-light dependency gets lugged even with the package disabled, so this commit makes python3-light a conditional dependency, similar to gensio in 0c245fd. Signed-off-by: Ernestas Kulik <ernestas.k@iconn-networks.com>

libgpiod: add python-setuptools host build dep

5f9f70c

If python3-gpiod is enabled and the python-setuptools host package is missing, the setuptools.build_meta import will cause a build failure. Fix this by adding a conditional build dependency.

ernestask force-pushed the conditional-deps branch from 2614c88 to 5f9f70c Compare May 1, 2026 09:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libgpiod: Make Python bindings optional#29165

libgpiod: Make Python bindings optional#29165
ernestask wants to merge 2 commits intoopenwrt:masterfrom
ernestask:conditional-deps

ernestask commented Apr 16, 2026 •

edited

Loading

Uh oh!

pprindeville left a comment

Uh oh!

pprindeville Apr 16, 2026

Uh oh!

ernestask Apr 16, 2026

Uh oh!

ernestask Apr 16, 2026

Uh oh!

pprindeville Apr 16, 2026

Uh oh!

ernestask Apr 16, 2026

Uh oh!

mhei commented Apr 17, 2026

Uh oh!

mhei Apr 26, 2026

Uh oh!

ernestask Apr 27, 2026

Uh oh!

Uh oh!

commodo commented May 1, 2026

Uh oh!

ernestask commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ernestask commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Package Details

🧪 Run Testing Details

✅ Formalities

Uh oh!

pprindeville left a comment

Choose a reason for hiding this comment

Uh oh!

pprindeville Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ernestask Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ernestask Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

pprindeville Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

ernestask Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

mhei commented Apr 17, 2026

Uh oh!

mhei Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

ernestask Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

commodo commented May 1, 2026

Uh oh!

ernestask commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ernestask commented Apr 16, 2026 •

edited

Loading